fix: remove resource refresh from output plans (#40)

This removes the terraform resource refresh output
from plans that only have output changes.

src/github.js

@@ -91,9 +91,16 @@ const removePlanRefresh = (plan) => {
   const startTokens = [
     "No changes. Infrastructure is up-to-date",
     "Resource actions are indicated with the following symbols",
+    "Changes to Outputs",
   ];
+
+  // This will only strip the first refresh token it finds in the plan ouput
   for (let token of startTokens) {
-    plan = plan.substring(plan.indexOf(token));
+    let index = plan.indexOf(token);
+    if (index > -1) {
+      plan = plan.substring(index);
+      break;
+    }
   }
   return plan;
 };

test/github.test.js

@@ -197,14 +197,20 @@ describe("removePlanRefresh", () => {
     ~ update in-place
     - destroy
 
-    Terraform will perform the following actions:`;
+    Terraform will perform the following actions:
+
+    Changes to Outputs:
+      foo=bar`;
     const expected = `Resource actions are indicated with the following symbols:
 
     + create  
     ~ update in-place
     - destroy
 
-    Terraform will perform the following actions:`;
+    Terraform will perform the following actions:
+
+    Changes to Outputs:
+      foo=bar`;
     expect(removeRefreshOutput(plan)).toBe(expected);
   });
 
@@ -224,6 +230,23 @@ describe("removePlanRefresh", () => {
     expect(removeRefreshOutput(plan)).toBe(expected);
   });
 
+  test("remove refresh for plan with only output changes", async () => {
+    const plan = `aws_lambda_permission.api: Refreshing state... [id=AllowAPIGatewayInvoke]
+    aws_api_gateway_integration.integration: Refreshing state... [id=agi]
+
+    Changes to Outputs:
+      + scan_websites_kms_key_arn = "arn:aws:kms:ca-central-1:12345:key/67890"
+
+    You can apply this plan to save these new output values to the Terraform
+    state, without changing any real infrastructure.`;
+    const expected = `Changes to Outputs:
+      + scan_websites_kms_key_arn = "arn:aws:kms:ca-central-1:12345:key/67890"
+
+    You can apply this plan to save these new output values to the Terraform
+    state, without changing any real infrastructure.`;
+    expect(removeRefreshOutput(plan)).toBe(expected);
+  });
+
   test("no change if start tokens do not exist", async () => {
     const plan = `This is a string without any plan start tokens
     for good measure, there's a line break in the mix`;