feat: add shellcheck to CI workflow (#27)

cds-snc · Jun 30, 2021 · 796cd16 · 796cd16
1 parent 75496d5
commit 796cd16
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -25,4 +25,5 @@ jobs:
       - run: npm run lint
       - run: npm run format:check
       - run: npm audit
-      - run: npm test
+      - run: npm test
+      - run: docker run -v "$PWD:/mnt" koalaman/shellcheck:v0.7.2 -P ./bin/ -x ./src/**/*.sh
diff --git a/src/policy/build.sh b/src/policy/build.sh
@@ -2,7 +2,7 @@
 set -euo pipefail
 IFS=$'\n\t'
 
-POLICY_DIR="$(dirname ${BASH_SOURCE[0]})"
+POLICY_DIR="$(dirname "${BASH_SOURCE[0]}")"
 
 # Build the Open Policy Agent policy WebAssembly module (.wasm) from the .rego files
 opa build -t wasm \
@@ -15,7 +15,7 @@ mv policy.wasm "$POLICY_DIR"
 rm bundle.tar.gz
 
 # Base 64 encode and write the policy.js that is used by the action
-POLICY_BASE64="$(base64 $POLICY_DIR/policy.wasm)"
+POLICY_BASE64="$(base64 "$POLICY_DIR"/policy.wasm)"
 echo "
 \"use strict\"
 // Auto-generated by 'npm run policy'