[RELEASE] UI Changes and Fixes #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #173
Minor change to translation string
Remove Canada.ca link in footer
* feat: add google tag manager * chore: add plugin to nuxt config * ci: add google tag manager to terraform * ci: add tf vars to gh actions * ci: add google tag manager id to staging
* fix: add back removed div * ci: add staging branch to gh actions * ci: future proofing nuxt3 * fix: lint fixes
Copied from the PULL_REQUEST_TEMPLATE folder
* Minor change Fixes #173 * Remove Canada.ca link in footer Fixes #174 * Right align * feat: add google tag manager (#200) * feat: add google tag manager * chore: add plugin to nuxt config * ci: add google tag manager to terraform * ci: add tf vars to gh actions * ci: add google tag manager id to staging * Fix/ci issues (#204) * fix: add back removed div * ci: add staging branch to gh actions * ci: future proofing nuxt3 * fix: lint fixes * docs: add PR templates (#205) Co-authored-by: Anik Brazeau <[email protected]> Co-authored-by: Dylan <[email protected]> Co-authored-by: Anik Brazeau <[email protected]>
fix: breadcrumbs accessibility
* docs: update contentful vars * docs: adding scripts to make setting env vars easier * docs: update documentation on running the app * docs: update readme * docs: update readme * docs: add links * docs: update links * docs: add link to translation documentation * docs: small changes * docs: add conventional commit into the readme * docs: update info for pr preview url
Add staging link and release process
feat: resource jump links
added 15 commits
January 10, 2023 15:41
fix: H1 consistency across site
fix: make paragraph spacing consistent
fix: cmd-to-open resource changes current resource
fix: missing breadcrumbs on about, contact and legal pages
daine
changed the title
daine
changed the title
daine
requested review from
realdylanzheng,
anikbrazeau,
ClementineHahn,
hillaryl and
janicelagiorgia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Included in this release:
Main - https://staging.learning-resources.cdssandbox.xyz/
EN - https://en.staging.learning-resources.cdssandbox.xyz/
FR - https://fr.staging.learning-resources.cdssandbox.xyz/fr/
After merge, do this:
From your terminal, make sure you are in the
mainbranch, then typeThis bumps up the release version