Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new page templates overview page #430

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

daine
Copy link
Collaborator

@daine daine commented Oct 5, 2024

Summary | Résumé

  • New pages for Page Templates
  • Page Templates Overview page
  • Removed Contact Us from top nav, moved to the footer
  • Added Page Templates to top nav, replacing Contact Us
  • Updated Report an Issue - created a partial, but the new design has the link as a button. We can make it uniform and remove the extra content on the Get Involved page to just use the partial instead.

Links

Issues:

  • "Obligatoire pour Canada.ca" tag / badge on card is more than 20 characters long. I have it set to "Obligatoire pour Ca" at the moment just to get it to display but this needs to be fixed. -> Suggestion from Elise to use "Requis sur Canada.ca"

To do before release

After templates have been released:

  • Update link to Figma templates (EN + FR)
  • Update link to Figma basic page template (EN + FR)
  • Update link to Github basic page template (EN + FR)
  • Update link to Github basic page template with table of contents (EN + FR)

Previews

English

French

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-430.d35vdwuoev573o.amplifyapp.com

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-430.djtlis5vpn8jd.amplifyapp.com

@SmartMouthWords
Copy link
Contributor

Checking with @EliseKa on the translation. We want to use a badge on components and page templates that state "Required for Canada.ca". The French "Obligatoire Canada.ca" is too many characters. There's a 20 character limit. Could "requis par Canada,ca:, "requis Canada.ca" or "requis Canada.ca" work as a replacement?
The meaning to convey is that it's needed for/on Canada.ca pages but "pour" and "dans" make the string too long.

@EliseKa
Copy link
Collaborator

EliseKa commented Oct 16, 2024

@SmartMouthWords I'd recommend using Requis sur Canada.ca (exactly 20 ch.), which fits better the meaning you want to convey :)

@SmartMouthWords
Copy link
Contributor

For the "Report an issue" and "Help us improve" sections, can we use the same pattern as the Get Involved page uses with the link for "Report an issue"?

@melaniebmn
Copy link
Collaborator

@daine update for next week: @SmartMouthWords and I decided to combine the "Report an issue" and "Help us improve" sections into one "Give feedback" section. I created a new partial for this and added it to both, the get involved page and the page template overview page.

Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing

src/en/page-templates/basic/code.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ethanWallace ethanWallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Now we just need to merge everything else and update the links to them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants