-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: new page templates overview page #430
base: main
Are you sure you want to change the base?
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Checking with @EliseKa on the translation. We want to use a badge on components and page templates that state "Required for Canada.ca". The French "Obligatoire Canada.ca" is too many characters. There's a 20 character limit. Could "requis par Canada,ca:, "requis Canada.ca" or "requis Canada.ca" work as a replacement? |
@SmartMouthWords I'd recommend using |
For the "Report an issue" and "Help us improve" sections, can we use the same pattern as the Get Involved page uses with the link for "Report an issue"? |
@daine update for next week: @SmartMouthWords and I decided to combine the "Report an issue" and "Help us improve" sections into one "Give feedback" section. I created a new partial for this and added it to both, the get involved page and the page template overview page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Now we just need to merge everything else and update the links to them :)
Summary | Résumé
Links
Issues:
To do before release
After templates have been released:
Previews
English
French