Merge pull request #244 from cds-snc/update-font-awesome-link

improve font awesome installation instructions
cds-snc · Nov 23, 2023 · b024d72 · b024d72
2 parents 2ce9f68 + 91bf3a9
commit b024d72
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 6 deletions.
diff --git a/src/_data/installation.js b/src/_data/installation.js
@@ -33,6 +33,7 @@ module.exports = {
         heading: 'Add the code',
         place:
           'Place the following code in the <head> element of your project:',
+        icons: 'to access icons, import Font Awesome',
         note: 'Note: <script type="module"> requires a server to load properly. If developing locally, please use <script nomodule>.',
       },
       choose: {
@@ -49,6 +50,7 @@ module.exports = {
         heading: 'Install with npm',
         install: 'Navigate to the root folder of your project and run:',
         place: 'Place the following code in the <head> element of your site:',
+        icons: 'to access icons, import Font Awesome',
       },
       other: {
         paragraph:
@@ -116,6 +118,7 @@ module.exports = {
         heading: 'Ajoutez le code',
         place:
           "Insérez le code suivant dans l'élément <head> de votre projet :",
+        icons: 'pour avoir accès aux icônes, installer Font Awesome',
         note: 'Remarque : <script type="module"> nécessite un serveur pour le chargement. Pour le développement local, veuillez utiliser <script nomodule>.',
       },
       choose: {
@@ -134,6 +137,7 @@ module.exports = {
         install:
           "Naviguez jusqu'au dossier racine de votre projet et exécutez :",
         place: "Insérez le code suivant dans l'élément <head> de votre site :",
+        icons: 'pour avoir accès aux icônes, installer Font Awesome',
       },
       other: {
         paragraph:

diff --git a/src/_includes/partials/installation/step-2-cdn.njk b/src/_includes/partials/installation/step-2-cdn.njk
@@ -6,8 +6,8 @@
   <p class="mb-400">{{ installation[locale].step2.cdn.place }}</p>
 
 {% highlight "html" %}
-<!-- Font Awesome (Icons) -->
-<script src="{{ links.fontAwesome }}" crossorigin="anonymous"></script>
+<!-- Icons Font Awesome ({{ installation[locale].step2.cdn.icons }}) -->
+<link rel="stylesheet" href="{{ links.fontAwesome }}" crossorigin="anonymous">
 
 <!-- GC Design System -->
 <link rel="stylesheet" href="https://cdn.design-system.alpha.canada.ca/@cdssnc/gcds-components@latest/dist/gcds/gcds.css">

diff --git a/src/_includes/partials/installation/step-2-node.njk b/src/_includes/partials/installation/step-2-node.njk
@@ -12,8 +12,8 @@
   <p class="mt-500 mb-400">{{ installation[locale].step2.node.place }}</p>
 
 {% highlight "html" %}
-<!-- Font Awesome (Icons) -->
-<script src="{{ links.fontAwesome }}" crossorigin="anonymous"></script>
+<!-- Icons Font Awesome ({{ installation[locale].step2.node.icons }}) -->
+<link rel="stylesheet" href="{{ links.fontAwesome }}" crossorigin="anonymous">
 
 <!-- GC Design System -->
 <link rel="stylesheet" href="/node_modules/@cdssnc/gcds-components/dist/gcds/gcds.css">

diff --git a/src/en/en.json b/src/en/en.json
@@ -56,7 +56,7 @@
 
     "figma": "https://www.figma.com/file/mh2maMG2NBtk41k1O1UGHV/Canadian-Digital-Service%E2%80%A8---GC-Design-System?node-id=4%3A1006&t=qguKsJtr1ityUsUN-0",
 
-    "fontAwesome": "https://kit.fontawesome.com/892cb27850.js",
+    "fontAwesome": "https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.2/css/all.min.css",
 
     "github": "https://github.com/cds-snc/gcds-components",
     "githubDocsIssues": "https://github.com/cds-snc/gcds-docs/issues",

diff --git a/src/fr/fr.json b/src/fr/fr.json
@@ -56,7 +56,7 @@
 
     "figma": "https://www.figma.com/file/mh2maMG2NBtk41k1O1UGHV/Canadian-Digital-Service%E2%80%A8---GC-Design-System?node-id=4%3A1006&t=qguKsJtr1ityUsUN-0",
 
-    "fontAwesome": "https://kit.fontawesome.com/892cb27850.js",
+    "fontAwesome": "https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.4.2/css/all.min.css",
 
     "github": "https://github.com/cds-snc/gcds-components",
     "githubDocsIssues": "https://github.com/cds-snc/gcds-docs/issues",