Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure release: 1.2.42 #1533

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Infrastructure release: 1.2.42 #1533

merged 1 commit into from
Nov 16, 2023

Conversation

patheard
Copy link
Member

@patheard patheard commented Nov 16, 2023

Summary

Update the CloudWatch alarm translation suppression patterns.

Related

@patheard patheard self-assigned this Nov 16, 2023
Copy link

Production: alarms

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 2 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_cloudwatch_log_metric_filter.wordpress_errors
aws_cloudwatch_log_metric_filter.wordpress_warnings
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_cloudwatch_log_metric_filter.wordpress_errors will be updated in-place
  ~ resource "aws_cloudwatch_log_metric_filter" "wordpress_errors" {
        id             = "WordPressErrors"
        name           = "WordPressErrors"
      ~ pattern        = "[(w1=\"*Failed*\" || w1=\"*failed*\" || w1=\"*Error*\" || w1=\"*error*\" || w1=\"*Fatal*\" || w1=\"*fatal*\") && w1!=\"*AH01276*\" && w1!=\"*AH01630*\" && w1!=\"*AH01797*\" && w1!=\"*action=lostpassword&error*\" && w1!=\"*database error*\" && w1!=\"*GET /notification-gc-notify/wp-json/wp/v2/pages*\" && w1!=\"*HTTP/1.1\\\" 403*\" && w1!=\"*HTTP/1.1\\\" 404*\" && w1!=\"*Undefined constant*\" && w1!=\"*fr_FR.po*\"]" -> "[(w1=\"*Failed*\" || w1=\"*failed*\" || w1=\"*Error*\" || w1=\"*error*\" || w1=\"*Fatal*\" || w1=\"*fatal*\") && w1!=\"*AH01276*\" && w1!=\"*AH01630*\" && w1!=\"*AH01797*\" && w1!=\"*action=lostpassword&error*\" && w1!=\"*database error*\" && w1!=\"*GET /notification-gc-notify/wp-json/wp/v2/pages*\" && w1!=\"*HTTP/1.1\\\" 403*\" && w1!=\"*HTTP/1.1\\\" 404*\" && w1!=\"*Undefined constant*\" && w1!=\"*/usr/src/wordpress/wp-content/languages*\"]"
        # (1 unchanged attribute hidden)

        # (1 unchanged block hidden)
    }

  # aws_cloudwatch_log_metric_filter.wordpress_warnings will be updated in-place
  ~ resource "aws_cloudwatch_log_metric_filter" "wordpress_warnings" {
        id             = "WordPressWarnings"
        name           = "WordPressWarnings"
      ~ pattern        = "[(w1=\"*Warning*\" || w1=\"*warning*\") && w1!=\"*Undefined array key*c3-cloudfront-clear-cache*\" && w1!=\"*fr_FR.po*\" && w1!=\"*chmod()*\"]" -> "[(w1=\"*Warning*\" || w1=\"*warning*\") && w1!=\"*Undefined array key*c3-cloudfront-clear-cache*\" && w1!=\"*/usr/src/wordpress/wp-content/languages*\" && w1!=\"*chmod()*\"]"
        # (1 unchanged attribute hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Cloudwatch log metric pattern is invalid: ["aws_cloudwatch_log_metric_filter.wordpress_ecs_warn_error_event"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.alb_ddos"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.alb_target_response_time_average"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.alb_target_unhealthy_host"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cloudfront_4xx_response"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.cloudfront_ddos"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ecs_cpu_utilization"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.ecs_memory_utilization"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.rds_aurora_replica_lag"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.rds_cpu_utilization_reader"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.rds_cpu_utilization_writer"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.rds_freeable_memory_reader"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.rds_freeable_memory_writer"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.route53_ddos"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.wordpress_database_errors"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.wordpress_ecs_warn_error_event"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.wordpress_errors"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.wordpress_failed_login"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.wordpress_suspicious_login"]
WARN - plan.json - main...

@patheard patheard requested a review from a team November 16, 2023 19:47
@patheard patheard enabled auto-merge (squash) November 16, 2023 20:10
@patheard patheard merged commit 0043d5a into main Nov 16, 2023
16 checks passed
@patheard patheard deleted the infrastructure/1.2.42 branch November 16, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants