Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build.sh script and more base image variations #90

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Toilal
Copy link
Contributor

@Toilal Toilal commented May 9, 2020

I need a xenial based image for cdrx/pyinstaller-linux, for a native module to compile properly (jsonnet). So I made those changes to add more base image variations on this project.

For now, I have written a build.sh script to build all images with the tags I expect to find on docker hub. I hope those tags could be added to the automated build too :)

It also contains a new DISABLE_REQUIREMENTS environment variable to avoid entrypoint "pip install -r requirements.txt". In my use case, I need to install a pre-build wheel package before invoking requirements installation, as my windows build won't compile the jsonnet module (So I have to install it before from a prebuilt wheel).

@Toilal Toilal force-pushed the more-variations branch 2 times, most recently from e62883e to 1cbbeb7 Compare May 9, 2020 09:51
@Toilal Toilal force-pushed the more-variations branch from 1cbbeb7 to eb3bc70 Compare May 9, 2020 11:05
@malwaredllc
Copy link

@Toilal Do you happen to know if adding git to the Wine server is possible? My requirements.txt file contains a reference to git which is causing it to fail when compiling an executable for Windows, as the Wine server does not have git installed.

Example in requirements.txt
git+https://github.com/jtgrassie/pyrx.git#egg=pyrx

@Toilal
Copy link
Contributor Author

Toilal commented May 10, 2020

@Toilal Do you happen to know if adding git to the Wine server is possible? My requirements.txt file contains a reference to git which is causing it to fail when compiling an executable for Windows, as the Wine server does not have git installed.

Example in requirements.txt
git+https://github.com/jtgrassie/pyrx.git#egg=pyrx

Don't use git and replace the requirements with a link to the zip archive, available on the github "Download sources" button => https://github.com/jtgrassie/pyrx/archive/master.zip#egg=pyrx

@Toilal
Copy link
Contributor Author

Toilal commented Jun 8, 2020

@cdrx could you have a look to this pull request ?

@Toilal
Copy link
Contributor Author

Toilal commented Aug 27, 2020

@cdrx , sorry if it sounds like spam, but could you have a look to this pull request ? Do you still maintain this repository ?

@Toilal
Copy link
Contributor Author

Toilal commented Sep 8, 2020

Those images are now available on docker hub, under toilal/pyinstaller-linux and toilal/pyinstaller-windows repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants