-
-
Notifications
You must be signed in to change notification settings - Fork 212
Allow "hitsPerPage" and "page" query parameters #192
base: master
Are you sure you want to change the base?
Conversation
Any questions/clarifications needed here? I'm happy to chat. |
Anywhere I can drop a few $'s to get this & #191 looked at? :) cc @PeterDaveHello |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request and sorry for the late review!
There are few empty line changes not related to the function itself, please revert it.
I have only two concerns here:
- Would
hitsPerPage
be appropriate enough or can we use something more friendly thanhits
here? - A little bit familiar with the above issue, I wonder how many websites using page = 0 as the first page in the parameter? What do you think about we treat 1 as the first page and just minus one and then send to API?
I went with
Same point here as with the |
This PR allows the apiServer to pass through
hitsPerPage
andpage
query params, as per the Algolia apiIncludes:
apiServer.js
to allow the passing of the params