Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: declare support for jsii-rosetta 5.3 #1248

Merged
merged 3 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/release.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/upgrade-dev-deps-main.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/workflows/upgrade-main.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ const project = new CdklabsTypeScriptProject({
},
autoApproveUpgrades: true,

minNodeVersion: '16.0.0',
workflowNodeVersion: '16.x',
minNodeVersion: '18.12.0',
setNodeEngineVersion: false,
workflowNodeVersion: '18.x',
jestOptions: {
jestConfig: {
setupFilesAfterEnv: ['<rootDir>/test/setup-jest.ts'],
Expand All @@ -66,6 +67,7 @@ new RosettaPeerDependency(project, {
[RosettaVersionLines.V5_0]: '~5.0.14',
[RosettaVersionLines.V5_1]: '~5.1.2',
[RosettaVersionLines.V5_2]: '~5.2.0',
[RosettaVersionLines.V5_3]: '~5.3.0',
},
});

Expand Down
9 changes: 3 additions & 6 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions projenrc/rosetta.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export enum RosettaVersionLines {
V5_0,
V5_1,
V5_2,
V5_3,
}

export interface RosettaPeerDependencyOptions {
Expand Down
8 changes: 7 additions & 1 deletion test/docgen/view/_npm.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ChildProcess, spawn } from 'child_process';
import { EventEmitter } from 'events';
import { tmpdir } from 'os';
import { Readable, Writable } from 'stream';
import { Pipe, Readable, Writable } from 'stream';
import { NoSpaceLeftOnDevice, NpmError, UnInstallablePackageError } from '../../../src';
import { Npm } from '../../../src/docgen/view/_npm';

Expand Down Expand Up @@ -146,6 +146,8 @@ class MockChildProcess extends EventEmitter implements ChildProcess {
null as any,
] as ChildProcess['stdio'];

public readonly channel?: Pipe | null | undefined;

public constructor(
public readonly exitCode: number | null,
{
Expand All @@ -162,6 +164,10 @@ class MockChildProcess extends EventEmitter implements ChildProcess {
});
}

[Symbol.dispose](): void {
throw new Error('Method not implemented.');
}

public addListener(): never {
throw new UnsupportedCallError();
}
Expand Down
56 changes: 23 additions & 33 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.