-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Serverless Nag Pack #1793
base: main
Are you sure you want to change the base?
feat: Serverless Nag Pack #1793
Conversation
Co-authored-by: Arun Donti <[email protected]>
Co-authored-by: Arun Donti <[email protected]>
Co-authored-by: Arun Donti <[email protected]>
Co-authored-by: Arun Donti <[email protected]>
Test Suites: 50 passed, 50 total |
|
100% code coverage on all the rules, all the rules have been unit tested on L1 and L2 constructs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a large change thus I will go through multiple iterations of reviews.
In addition to the proposed changes to descriptions, please link this PR to the issue you created
Co-authored-by: Arun Donti <[email protected]>
Co-authored-by: Arun Donti <[email protected]>
*/ | ||
private checkLambda(node: CfnResource) { | ||
this.applyRule({ | ||
info: 'The Lambda function should have tracing set to Tracing.ACTIVE.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
info: 'The Lambda function should have tracing set to Tracing.ACTIVE.', | |
info: 'The Lambda function does not have tracing set to Tracing.ACTIVE.', |
does not
was appropriate wording
}); | ||
|
||
this.applyRule({ | ||
info: 'Lambda Event Source Mappings have a destination configured for failed invocations.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The info on applyRule
needs to declare what's wrong with the specific, singular resource that violated the rule.
info: 'Lambda Event Source Mappings have a destination configured for failed invocations.', | |
info: 'The Lambda Event Source Mapping does not have a destination configured for failed invocations.', |
Fixes #1676