feat: lambda logging rules #1677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontirun
requested changes
May 6, 2024
There was a problem hiding this comment.
Please add this to the Additional Rules section in the RULES.mdfile.
That section lists rules that are not currently part of any included NagPacks
Co-authored-by: Arun Donti <[email protected]>
Co-authored-by: Arun Donti <[email protected]>
Co-authored-by: Arun Donti <[email protected]>
dontirun
requested changes
May 22, 2024
Kevinwochan
force-pushed
the
feat/serverless-nag-pack
branch
from
e9351f7 to
bc1d61c
Compare
|
I've written up rules for the rest of the pack. |
dontirun
requested changes
Jun 24, 2024
RULES.md
Outdated
| @@ -702,6 +702,7 @@ A collection of community rules that are not currently included in any of the pr | |||
| | Rule ID | Cause | Explanation | | |||
| | --------------------- | ------------------------------------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | LambdaFunctionUrlAuth | The Lambda Function URL allows for public, unauthenticated access. | AWS Lambda Function URLs allow you to invoke your function via a HTTPS end-point, setting the authentication to NONE allows anyone on the internet to invoke your function. | | |||
| | LambdaLogLevel | The Lambda Function does not define an explicit Log Level | For cost optimization purposes, you should explicitly define the required log level for cost effective storage of Lambda Logs. | | |||
There was a problem hiding this comment.
This is for the wrong rule
test/rules/Lambda.test.ts
Outdated
| @@ -351,4 +357,63 @@ describe('AWS Lambda', () => { | |||
| validateStack(stack, ruleId, TestType.VALIDATION_FAILURE); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('LambdaLogLevel: Lambda functions have a explicit log level', () => { | |||
There was a problem hiding this comment.
It looks like these tests are for the wrong rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serverless Nag Pack - lambda logging rules
First rule of many to check if this is in-line with the team's standards