Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask: [email protected] #116

Closed
wants to merge 5 commits into from
Closed

Conversation

cdalvaro
Copy link
Owner

Add LTS salt 3006.9 cask

@cdalvaro cdalvaro added the new cask PR adds a new cask to this Homebrew tap label Nov 23, 2024
@cdalvaro cdalvaro requested a review from Copilot November 23, 2024 09:21
@cdalvaro cdalvaro self-assigned this Nov 23, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 suggestions.

Comments skipped due to low confidence (4)

lib/patches/salt.rb:20

  • [nitpick] The variable name 'random_str' is ambiguous. It should be renamed to 'random_filename_suffix'.
random_str = (0...8).map { rand(65..90).chr }.join

lib/patches/salt.rb:23

  • The 'system_command' call lacks error handling. Consider adding error handling to ensure robustness.
system_command "plutil", args: ["-lint", new_plist_file]

lib/patches/salt.rb:26

  • The 'system_command' call lacks error handling. Consider adding error handling to ensure robustness.
system_command "mv", args: [new_plist_file, plist_file], sudo: true

lib/patches/salt.rb:29

  • The 'system_command' call lacks error handling. Consider adding error handling to ensure robustness.
system_command "chown", args: ["root:wheel", plist_file], sudo: true

Casks/[email protected] Outdated Show resolved Hide resolved
lib/patches/salt.rb Outdated Show resolved Hide resolved
@cdalvaro cdalvaro added the pr-pull Homebrew pull request label Nov 23, 2024
@github-actions github-actions bot closed this in 9be23fb Nov 23, 2024
@github-actions github-actions bot closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new cask PR adds a new cask to this Homebrew tap pr-pull Homebrew pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant