fix: fixedDecimalValue issue #292 and handle fixedDecimalValue 0 #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchanxzy
force-pushed
the
fix/fixedDecimalValue-handle-changes
branch
from
c1eba67 to
3302541
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 402 406 +4
Branches 155 157 +2
=========================================
+ Hits 402 406 +4
☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 3.6.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #292 regarding
fixedDecimalValue.Also, fixes/better handles if
fixedDecimalValue = 0. Prior to this fix,0would be ignored, which isn't exactly correct.