Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to edit a saved list #25

Closed
2 tasks done
cch5ng opened this issue Mar 20, 2017 · 6 comments
Closed
2 tasks done

ability to edit a saved list #25

cch5ng opened this issue Mar 20, 2017 · 6 comments
Assignees
@cch5ng
Labels
please retest
Milestone
beta

Comments

@cch5ng
Copy link
Owner

cch5ng commented Mar 20, 2017 •
edited
Loading

think this requires

  • create or reuse the all questions template; figure out how it must differ and if there is some way to reuse the original component
  • need to store the currently selected questions in state to auto populate check box selection
@cch5ng cch5ng modified the milestone: beta Mar 20, 2017
@cch5ng
Copy link
Owner Author

cch5ng commented Mar 24, 2017 •
edited
Loading

state:

  • track whether view is in read only vs edit mode
  • track the list of currently saved questions (coming from store)
  • this item is buggy (Save click in edit mode is not updating indexedDb currently)
  • Save updates indexeddb but going to Read view doesn't update the list automatically
    • state is actually updated but doesn't get reflected in view; also the order of questions is a bit wonky (relative to the original list order)
  • track the list of currently saved questions (which might have been modified on the page)
    (fixed) * this item buggy

read view: only show saved questions (from indexeddb)
edit view: show the form view (with checked questions)

@cch5ng cch5ng self-assigned this Mar 26, 2017
@cch5ng
Copy link
Owner Author

cch5ng commented Mar 27, 2017 •
edited
Loading

moved to #48 (enhance)

considerations (delete confirmation vs undo option):

http://ux.stackexchange.com/questions/71960/deletion-confirm-or-undo-which-is-the-better-option-and-why

@cch5ng
Copy link
Owner Author

cch5ng commented Mar 28, 2017 •
edited
Loading

cur behavior:
when a fave list is opened (read), the state is populated per category for the saved list of questions

  • think instead of displaying from state.questions, better to iterate over the separate state.categoryX items (logic would be very similar but not exactly like that in AllQuestions render() funct)
  • this requires creating a dynamic list of category names (probably the concatenated name)
    • ['GeneralQuestions', 'HTMLQuestions', 'CSSQuestions', ...] (this will indicate the order that question sets should be displayed)
    • separately define a helper for name concat; this is done mult times
  • break out into separate issues
    • event handler for delete links (from the favorites view)
    • getting the short questions lists to display in the original list order??

cch5ng added a commit that referenced this issue Mar 28, 2017
@cch5ng
fix: #25; add viewState, add renderEditQuestions(), add handleViewMen…
8f050d4 
…u(), placeholder isChecked()
cch5ng added a commit that referenced this issue Mar 28, 2017
@cch5ng
fix: #25; update renderEditQuestions() and isChecked(); but handling …
a173404 
…checkbox click events is broken
cch5ng added a commit that referenced this issue Mar 28, 2017
@cch5ng
fix: #25; updated componentDidUpdate() and isChecked() to get questio…
d9964aa 
…n checked status more consistently
cch5ng added a commit that referenced this issue Mar 28, 2017
@cch5ng
fix: #25; update handleSaveButton(e) to use existing key and update i…
7ef0231 
…ndexeddb
cch5ng added a commit that referenced this issue Mar 28, 2017
@cch5ng
fix: #25; add getCategoriesList(), shortCategory(categ) helpers
c3b9672
cch5ng added a commit that referenced this issue Mar 28, 2017
@cch5ng
fix: #25; cleanup and update render() to get latest saved questions m…
77ecd5e 
…ore dynamically
@cch5ng
Copy link
Owner Author

cch5ng commented Mar 28, 2017

the logic was implemented but think it should be a little more thoroughly tested before pushing and also updating the demo

@cch5ng cch5ng closed this as completed in f439fa1 Mar 29, 2017
cch5ng added a commit that referenced this issue Mar 29, 2017
@cch5ng
cleanup: #25
e2a1271
cch5ng added a commit that referenced this issue Mar 29, 2017
@cch5ng
Merge branch 'master' into edit_list/#25
bbc2eef
cch5ng added a commit that referenced this issue Mar 29, 2017
@cch5ng
Edit list/#25 (#61)
125312c 
* fix: #25; add viewState, add renderEditQuestions(), add handleViewMenu(), placeholder isChecked()

* fix: #25; update renderEditQuestions() and isChecked(); but handling checkbox click events is broken

* fix: #25; updated componentDidUpdate() and isChecked() to get question checked status more consistently

* fix: #25; update handleSaveButton(e) to use existing key and update indexeddb

* fix: #25; add getCategoriesList(), shortCategory(categ) helpers

* fix: #25; cleanup and update render() to get latest saved questions more dynamically

* cleanup: #25
@cch5ng
Copy link
Owner Author

cch5ng commented Mar 29, 2017 •
edited
Loading

status: pushed latest to surge

  • should just double check and test basic feature changes

@cch5ng cch5ng reopened this Mar 29, 2017
@cch5ng
Copy link
Owner Author

cch5ng commented Mar 29, 2017

seems to pass basic manual tests

  • create list (add items)
  • add items to existing list, save
  • remove items from existing list, save

@cch5ng cch5ng closed this as completed Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cch5ng cch5ng

Labels
please retest
Projects
None yet
Milestone
beta
Development

No branches or pull requests
1 participant
@cch5ng