Skip to content

Commit

Permalink
Merge branch 'master' into edit_list/#25
Browse files Browse the repository at this point in the history
  • Loading branch information
cch5ng authored Mar 29, 2017
2 parents e2a1271 + f439fa1 commit bbc2eef
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
### react-frontend-interview2 (wip)
### react-fe-interview (wip)

* This is a version of a Front End Technical Interview app which generates random test questions (for interviewer or candidate preparing for interviews)

Expand All @@ -17,13 +17,15 @@ Using node v6.9.2 (via nvm)

[localforage](https://github.com/localForage/localForage/blob/master/docs/api.md) - this is a really handy library with a much easier api to use than the original indexedDB api

[gh pages module](https://medium.freecodecamp.com/surge-vs-github-pages-deploying-a-create-react-app-project-c0ecbf317089#.v5vwn6ddr) - I'm using an npm module that allows easier hosting of react applications on github pages
[surge module](https://medium.freecodecamp.com/surge-vs-github-pages-deploying-a-create-react-app-project-c0ecbf317089) - I'm using an npm module that allows easier hosting of react-router applications on a 3rd party host

### Running the Application

* Known issue: while you can access the demo using the url, http://cch5ng.github.io/react-frontend-interview2 there is an issue where the first view doesn't render until you click the logo or another nav link. The reason is that I'm redirecting my github projects to my private domain but this conflicts with the routes set up for react-router. Sorry! I will look into a fix <3
[demo version](http://fe-interview-react.surge.sh/)

Prereq to run the application locally
* Known issue: currently filtering on the surge host is not working; it does work when the application is run on a local server... looking into this, sorry!

Running the application locally

1 From the terminal: `npm install`

Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"test": "react-scripts test --env=jsdom",
"eject": "react-scripts eject",
"predeploy": "npm run build",
"deploy": "gh-pages -d build"
},
"homepage": "http://cch5ng.github.io/react-frontend-interview2"
"deploy": "gh-pages -d build",
"clean": "rm -rf node_modules/gh-pages/.cache"
}
}
1 change: 0 additions & 1 deletion src/components/Child.js
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ class Child extends Component {
*/
renderQuestions(idxCategory) {
var list;

return list;
}

Expand Down

0 comments on commit bbc2eef

Please sign in to comment.