Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbor.me off by one in comments for negative ints #41

Open
g-k opened this issue Mar 1, 2018 · 0 comments
Open

cbor.me off by one in comments for negative ints #41

g-k opened this issue Mar 1, 2018 · 0 comments

Comments

@g-k
Copy link

g-k commented Mar 1, 2018

For negative ints (major type 1) the diagnostic output is correct, but the comments on the right hand side look wrong. It looks like cbor.me is failing to subtract the -1 implicit in the negative int type.

For example, for hex 0x26 I see a comment of negative(6) and for 0x37 negative(23) (screenshots below).

cborbad6_stripped

cborbad23_stripped

If I'm just misunderstanding the comments then I think some clarifying message on the page would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant