zio integration #307
Closed
zio integration #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpennell
reviewed
Nov 13, 2019
|
|
||
| import scala.util.control.NonFatal | ||
|
|
||
| object zio { |
There was a problem hiding this comment.
Can we have this as ZioEffect similar to scalacache.CatsEffect.
It is common to import scalacache._ and this ends up shading the zio namespace.
There was a problem hiding this comment.
Thanks for your feedback. That sounds reasonable. I renamed the module object according your suggestion.
|
Thanks for contributing this! |
|
Thanks for the contribution here! I am going to close this since the library as a whole is moving away from having different modes (see #345). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Chris,
with this PR I made an integration for zio like there already exists for cats-effect, scalaz, try/future. Maybe you can have a look?
Karl