Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(nix): optimize build speed #234

Merged
merged 1 commit into from
Dec 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nix/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@

extension = pkgs.stdenvNoCC.mkDerivation {
inherit name version pname src;
buildInputs = [pkgs.nodejs pkgs.vsce pkgs.yarn];
buildInputs = [pkgs.nodejs pkgs.vsce];

# check in the ./themes/.flag so it doesn't prompt for initial rebuilds
patchPhase = ''
Expand All @@ -63,7 +63,7 @@
cp -r ${builder}/* dist/
touch ./themes/.flag
node dist/hooks/generateThemes.js
vsce package --yarn
vsce package --no-dependencies
runHook postBuild
'';

Expand Down
17 changes: 4 additions & 13 deletions nix/shell.nix
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
{pkgs ? import <nixpkgs> {}}: let
nodejs = pkgs.nodejs_18;
in
pkgs.mkShell {
buildInputs = with pkgs; [
alejandra
nil

nodejs
corepack
(yarn.override {inherit nodejs;})
];
}
{pkgs ? import <nixpkgs> {}}:
pkgs.mkShell {
buildInputs = with pkgs; [alejandra nil nodejs_18 corepack];
}