Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: java class/interface/record/enum/exception icons #247

Merged
merged 14 commits into from
Sep 13, 2024
Merged

Conversation

prazdevs
Copy link
Member

@prazdevs prazdevs commented Aug 15, 2024

closes #161

@sgoudham feel free to change/adapt class colors to what seems fitting, i used shades of blue as it was already blue. Also I didnt bind them to anything in VSC as it cannot differentiate the type of java file (besides extension)

Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for creating them, I think they look amazing!

image
(Ignore the Angular icon for Exception as I was just trying some things out)

A few comments from me:

  1. Looks like Exception is also supported so it'd be good to have an icon for that. For reference, Atom's icon is a lightning bolt as shown below:

    image

  2. I'd also remove all the existing java_alt icons and maybe just have one singular red duke icon since it is a mascot.

  3. I think it makes sense to prepend the icons with java- or equivalent to avoid conflicts with reserved keywords if people are auto-generating them. I know you said that it might be good to keep it vague but I think it's better to be specific since I think it's a bit unlikely that people will want to use Java class icons for Kotlin class icons. Happy to have my mind changed here though.

@sgoudham
Copy link
Contributor

sgoudham commented Sep 9, 2024

I've added an exception icon, removed the java_alt icons and renamed the icons to be prefixed with java-.
Going to leave it for a bit before merging in case you really disagree with some of my changes @prazdevs

@sgoudham
Copy link
Contributor

sgoudham commented Sep 9, 2024

Updated preview:

image

@sgoudham sgoudham changed the title feat: class/interface/record/enum icons feat: java class/interface/record/enum/exception icons Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Differentiate Java filetype icons by shape, instead of just colour
2 participants