Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager): add support for fuzzel #75

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

Anomalocaridid
Copy link
Contributor

Adds support for fuzzel.

@Anomalocaridid Anomalocaridid marked this pull request as draft January 28, 2024 03:12
@Anomalocaridid
Copy link
Contributor Author

Marking as draft because I realized I could add an accent option for the match text color, but it would require access to the palette brought in in #69 in order to translate the accent's color's name to its hex code.

@getchoo
Copy link
Member

getchoo commented Mar 13, 2024

Marking as draft because I realized I could add an accent option for the match text color, but it would require access to the palette brought in in #69 in order to translate the accent's color's name to its hex code.

is this something missing in upstream? it might be better contribute this there rather than use the palette. either way though, #69 has been merged so the palette is now an option

@Anomalocaridid Anomalocaridid force-pushed the fuzzel branch 11 times, most recently from 9fd3b9f to 8e2c65f Compare March 23, 2024 21:19
@Anomalocaridid Anomalocaridid marked this pull request as ready for review March 23, 2024 21:23
@Anomalocaridid
Copy link
Contributor Author

is this something missing in upstream? it might be better contribute this there rather than use the palette.

It's not a missing color in the theme. I just figured the accent could replace red for the match and selection-match colors. I am not sure how that could be implemented upstream.

@getchoo
Copy link
Member

getchoo commented Apr 7, 2024

this will need a rebase

@Anomalocaridid
Copy link
Contributor Author

Apparently there is a fairly straightforward way I could implement the accent color upstream, thanks to the recent RFC for whiskers: https://github.com/catppuccin/community/blob/main/rfc/CAT-0003-Whiskers.md#matrix. I am going to take care of that first and then update this PR afterwards.

@getchoo getchoo added the blocked Waiting on external changes label Apr 8, 2024
@getchoo
Copy link
Member

getchoo commented Jun 30, 2024

rebased onto main. still waiting on catppuccin/fuzzel#1

@getchoo getchoo force-pushed the fuzzel branch 2 times, most recently from 35c304d to 84f1e26 Compare June 30, 2024 07:03
@getchoo getchoo marked this pull request as draft June 30, 2024 07:03
@Anomalocaridid
Copy link
Contributor Author

Sorry, I was planning on taking care of rebasing myself once the changes to the fuzzel theme were merged.

@Anomalocaridid
Copy link
Contributor Author

catppuccin/fuzzel#1 has finally been merged and I have updated this PR accordingly. I believe this is now ready for review.

@Anomalocaridid Anomalocaridid marked this pull request as ready for review July 26, 2024 16:48
@getchoo getchoo removed the blocked Waiting on external changes label Aug 7, 2024
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the wait!

@getchoo getchoo changed the title feat(home-manager): init fuzzel module feat(home-manager): add support for fuzzel Aug 7, 2024
@getchoo getchoo merged commit 7e23de3 into catppuccin:main Aug 7, 2024
6 checks passed
@Anomalocaridid
Copy link
Contributor Author

No worries. Thank you!

@Anomalocaridid Anomalocaridid deleted the fuzzel branch August 7, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants