Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(home-manager): ensure xdg.enable using assertion #59

Merged

Conversation

Scrumplex
Copy link
Contributor

I don't think it's nice to enable options like these for the user. Instead we should just tell them to do it in their config.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xdg.enable needs to be set in test.nix, otherwise lgtm :)

modules/lib/default.nix Outdated Show resolved Hide resolved
@Scrumplex Scrumplex force-pushed the refactor/home-manager/assert-xdg.enable branch from 359e3f1 to 2455701 Compare November 3, 2023 16:32
@Scrumplex Scrumplex requested a review from getchoo November 3, 2023 16:36
@getchoo
Copy link
Member

getchoo commented Nov 3, 2023

thanks!

@getchoo getchoo merged commit a0e5082 into catppuccin:main Nov 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants