Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager): init swaylock module #54

Closed
wants to merge 2 commits into from

Conversation

Anomalocaridid
Copy link
Contributor

Adds support for swaylock.

In case it matters, this theme is from a third-party repo rather than one owned by the Catppuccin GitHub organization.

@getchoo
Copy link
Member

getchoo commented Nov 3, 2023

please see my comment from #55

this one was a bit harder since i was actually thinking of picking up swaylock soon too 😞

@getchoo getchoo closed this Nov 3, 2023
@Anomalocaridid
Copy link
Contributor Author

Closed because it has come to my attention that unofficial ports are not allowed.

@Anomalocaridid Anomalocaridid deleted the swaylock branch November 3, 2023 15:51
@Anomalocaridid Anomalocaridid restored the swaylock branch January 18, 2024 00:48
@Anomalocaridid
Copy link
Contributor Author

The swaylock theme is now official: https://github.com/catppuccin/swaylock.

I have updated my PR branch accordingly. Could this PR please be re-opened?

@Anomalocaridid
Copy link
Contributor Author

@getchoo Could this PR please be reopened? The swaylock theme is now official and I have updated my PR branch accordingly.

Although I just noticed this PR does not show the new changes, probably because they were made after it was closed. However, going directly to my branch at https://github.com/Anomalocaridid/ctp-nix/tree/swaylock does.

I apologize if I am overstepping any boundaries by pinging you. I am not sure how visible my last comment was given that this PR was already closed and you were the only other person to interact with this PR.

@getchoo
Copy link
Member

getchoo commented Mar 13, 2024

@Anomalocaridid sorry for not seeing this!

for some reason i can't reopen this pull request even though the branch has been restored; you'll need to make a new one if you're still up for it

@getchoo
Copy link
Member

getchoo commented Mar 13, 2024

nevermind, after commenting i can now?

edit: it let me hit comment reopen...but didn't reopen. thank you github. you'll still need to make another it seems :/

@Anomalocaridid
Copy link
Contributor Author

That's alright. Thanks anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants