Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fuzzel): correctly gatekeep module #370

Closed
wants to merge 1 commit into from
Closed

Conversation

isabelroses
Copy link
Member

No description provided.

@isabelroses
Copy link
Member Author

build is failing on darwin due to spotify-player

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream module already gates this behind programs.fuzzel.enable. This shouldn't be needed

@isabelroses
Copy link
Member Author

The upstream module already gates this behind programs.fuzzel.enable. This shouldn't be needed

the same could be said for fish and others but we do the same thing

enable = cfg.enable && config.programs.fish.enable;

@getchoo
Copy link
Member

getchoo commented Nov 30, 2024

the same could be said for fish and others but we do the same thing

That was honestly out of laziness when refactoring. Some home-manager modules will (correctly) guard applying their configs when they're not enabled, while others wont. Ideally we should be checking for this and only adding this guard when we have to (since it's pretty annoying)

@isabelroses isabelroses deleted the fix/fuzzel branch November 30, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants