feat(home-manager): add support for hyprlock #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #295 Config has been tested and is working |
|
Oops, just realised this doesn’t actually use the hyprlock port at all, so I need to remove that from sources.json The hyprlock port is only a configuration file? Why does it even exist when the hyprland port is all you need? IMO personalised configurations should not be included in the ctp org, it doesn’t even include the colour variables - wouldn’t it be better suited under |
42willow
force-pushed
the
feat/hyprlock
branch
from
959f4bd to
4a6e249
Compare
getchoo
requested changes
Sep 5, 2024
Should I disable the test in https://github.com/catppuccin/nix/blob/45745fe5960acaefef2b60f3455bcac6a0ca6bc9/tests/darwin.nix ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost identical to the hyprland home manager module, links the catppuccin source file so colour variables can be used in the config.
https://github.com/catppuccin/hyprlock
Thank you to @PerchunPak for her work in #293