fix(home-manager): use correct theme name #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelroses
reviewed
Jun 22, 2024
modules/home-manager/gtk.nix
Outdated
| variant = cfg.flavor; | ||
| }; | ||
| theme = { | ||
| name = "catppuccin-${cfg.flavor}-${cfg.accent}-${cfg.size}+default"; |
There was a problem hiding this comment.
i believe tweaks are added at the end. For example +default for no tweaks, +black for the black tweak.
There was a problem hiding this comment.
So the tweak to path mapping is this?
- black -> +black
- rimless -> +rimless
- normal -> +default
|
If I didn't mess up, |
eljamm
force-pushed
the
gtk
branch
2 times, most recently
from
97c9bd6 to
6ce6da4
Compare
|
Well, turns out I did mess up, but it should work now. |
- Theme name is all lowercase now - Change order from `flavor-size-accent-gtkTheme` to `flavor-accent-size+gtkTweaks`
|
So apparently it's just enough to append the tweaks at the end. In the derivation result, the names were being seperated by
I tested this on my machine and everything works great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The theme name does not correctly match the one from catppuccin-gtk which should be
catppuccin-${FLAVOR}-${ACCENT}-${SIZE}+${TWEAKS}as the Usage docs specify.Changes
flavor-size-accent-gtkThemetoflavor-accent-size+tweaks