-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enable
option globally
#124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not put it in modules/home-manager/globals.nix.
And I don't belive you need the flavour = lib.mkDefault cfg.flavour;
because of the aforementioned globals.
doing it |
Just tested on my own local config with: { inputs, ... }:
{
imports = [
inputs.catppuccin.homeManagerModules.catppuccin
];
catppuccin = {
enable = true;
flavour = "latte";
};
} And that works :) |
Many thanks @drupol as I was pulling my hair out to make it work 🙏 |
@isabelroses Anything else left to do in here? |
I don't think you need to add Other then that in my opinion its good but ultimately its up to @getchoo. |
I just fixed it. |
I'm using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for getting the ball rolling here btw :)
I updated the PR, WDYT ? |
Probably should rename PR to |
home-manager
moduleenable
option globally
Anything else to do? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Thank you so much! This really feels like a enhancement to this project |
This PR:
enable
option to enablecatppuccin
everywhere it canenableAll
setting #115I won't be able to test this until late tonight, help needed!