Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the column layout type #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add the column layout type #37

wants to merge 1 commit into from

Conversation

kjnsn
Copy link

@kjnsn kjnsn commented Oct 13, 2024

No description provided.

sgoudham
sgoudham reviewed Oct 13, 2024
View reviewed changes
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this layout born out of a usecase that you wanted for a port?
Trying to understand if a column layout would benefit any existing or new ports 🤔

sgoudham
sgoudham reviewed Oct 20, 2024
View reviewed changes
Copy link
Contributor

@sgoudham sgoudham left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismiss the previous comment, saw that you used this layout in the tmux port.
Will test out locally before approving as we don't have a test bed at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgoudham sgoudham sgoudham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjnsn @sgoudham