ci(lint): use wasm toolchain from nix #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as our only extra target is wasm - which nixpkgs' rust includes - we do
not require overlays
some other improvements include:
- better compat with stable nix
- `nix-build`, `nix-shell`, etc now work as expected and are in sync
with the flake's version
- using `nixpkgs-unstable` over `nixos-unstable`
- this benefits darwin users mainly, but we also get faster updates
- hopefully fixed CI!! (fingers crossed)
getchoo
force-pushed
the
ci/try-to-get-lint-working
branch
from
1404dcb to
6c8ac84
Compare
getchoo
force-pushed
the
ci/try-to-get-lint-working
branch
from
da4135b to
10761d5
Compare
this allows us to not have an extra file just for our package expression, and instead we can re-use what we define in our overlay
getchoo
force-pushed
the
ci/try-to-get-lint-working
branch
from
10761d5 to
432b7b0
Compare
sgoudham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.