fix(pdsch) #67
Merged
fix(pdsch) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests fail |
…es`. Aligned with MATLAB defaults. Also added MATLAB default value to `DMRSLength`. Closes catkira#66.
|
we should try to minimize API changes, or only do them with major version changes. But it's ok now, because not so many people are using it yet I guess :) |
|
until 1.0 everything is experimental :) |
I've been tying to keep everything the same way as MATLAB. And MATLAB has strict arguments order. So, new features needs to follow MATLAB, or we can align API to our needs? (I'd keep MATLAB-style for everything) |
|
yes keep it Matlab compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was missing
carrierargument innrPDSCHDMRSIndices. Aligned with MATLAB defaults. Also added MATLAB default value toDMRSLength. Closes #66.