analyzer: remove redundant if stmts

catenacyber · Nov 20, 2024 · f7c1bb9 · f7c1bb9
1 parent 33099e0
commit f7c1bb9
Showing 1 changed file with 8 additions and 16 deletions.
diff --git a/analyzer/analyzer.go b/analyzer/analyzer.go
@@ -102,28 +102,20 @@ func (n *perfSprint) run(pass *analysis.Pass) (interface{}, error) {
 			err   error
 		)
 		switch {
-		case calledObj == fmtErrorfObj && len(call.Args) == 1:
-			if n.errorf {
-				fn = "fmt.Errorf"
-				verb = "%s"
-				value = call.Args[0]
-			} else {
-				return
-			}
+		case calledObj == fmtErrorfObj && len(call.Args) == 1 && n.errorf:
+			fn = "fmt.Errorf"
+			verb = "%s"
+			value = call.Args[0]
 
 		case calledObj == fmtSprintObj && len(call.Args) == 1:
 			fn = "fmt.Sprint"
 			verb = "%v"
 			value = call.Args[0]
 
-		case calledObj == fmtSprintfObj && len(call.Args) == 1:
-			if n.sprintf1 {
-				fn = "fmt.Sprintf"
-				verb = "%s"
-				value = call.Args[0]
-			} else {
-				return
-			}
+		case calledObj == fmtSprintfObj && len(call.Args) == 1 && n.sprintf1:
+			fn = "fmt.Sprintf"
+			verb = "%s"
+			value = call.Args[0]
 
 		case calledObj == fmtSprintfObj && len(call.Args) == 2:
 			verbLit, ok := call.Args[0].(*ast.BasicLit)