-
Notifications
You must be signed in to change notification settings - Fork 563
Update trace-button.html #3559
base: master
Are you sure you want to change the base?
Update trace-button.html #3559
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it.
…On May 14, 2017 1:15 AM, "googlebot" ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
------------------------------
- If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data <https://cla.developers.google.com/clas> and verify
that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- If you signed the CLA as a corporation, please let us know the
company's name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3559 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKPbdNnjq5ljlMci33xZ63AGmG1prdpUks5r5ghAgaJpZM4NaLGD>
.
|
CLAs look good, thanks! |
Thanks so much for the pull request! But in catapult, we actually use rietveld for code reviews since it has integrated commit queue support. You can get instructions for sending a code review in rietveld here: https://github.com/catapult-project/catapult/blob/master/CONTRIBUTING.md Feel free to send the review to my chromium account, [email protected]. |
Cloning to my local machine is failing. |
I don't know what the problem is, but I googled |
Plz correct me where im doing wrong. sapna@sapna: |
I'm really sorry, it looks like you're using a 32 bit linux machine. We only support 64 bit. Can you try again from a 64 bit linux machine? |
Renamed the button name to re-run the benchmark from trace to TraceButton.