Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline sessions to the conversion script #12

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Add offline sessions to the conversion script #12

merged 5 commits into from
Oct 31, 2024

Conversation

alessandratrapani
Copy link
Collaborator

@alessandratrapani alessandratrapani commented Oct 29, 2024 •
edited
Loading

review after #11
Fix conversion scripts to work with offline sessions as well

@alessandratrapani alessandratrapani mentioned this pull request Oct 29, 2024
Open
29 tasks
@alessandratrapani alessandratrapani self-assigned this Oct 29, 2024
@alessandratrapani alessandratrapani marked this pull request as ready for review October 29, 2024 13:55
@h-mayorquin
Copy link
Collaborator

Can you merge main back into this so I can see the true diff? It looks like there are some changes still here even if #11 was merged.

h-mayorquin
h-mayorquin approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this for subject Ca_EEG3_1. It works but there is high memory usage pattern probably unrelated to this PR.

Let's merge this and investigate the memory problem outside.

@alessandratrapani alessandratrapani merged commit 62c30b6 into main Oct 31, 2024
@alessandratrapani alessandratrapani deleted the add_offline_sessions branch November 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-mayorquin h-mayorquin h-mayorquin approved these changes

Assignees

@alessandratrapani alessandratrapani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessandratrapani @h-mayorquin