Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): prussian blue and iodide effects visble on status screen, increase effectiveness of prussian blue #5811

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

A suggestion that came up in the BN discord was making the prussian blue and iodine effects visible on the effects screen since it can be hard to tell it's doing anything otherwise, and since antibiotics in BN are directly visible instead of hidden we don't have to fiddle with abstracting it behind a separate dosage-tracker effect.

Along the way I noticed the effect also really doesn't seem like it recovers very much radiation, and after some quick math uh...yeah.
image

Describe the solution

  1. Added names and descriptions to the prussian blue and iodine effects.
  2. Reduced chance_min of prussian blue from 600 to 100. This should make it recover roughly 36 rads across an hour, which combined with the natural recovery rate makes for a 50% increase over just toughing it out (before it made you lose rads ~8.333% faster). Compare iodine reducing incoming radiation by 70% with no radiation mutations (https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/src/suffer.cpp#L1630), this makes it better than useless but reducing incoming rads is still more effective.
  3. Misc: Added JSON comments to both effects outlining how effective they are with references to the relevant code.

Describe alternatives you've considered

Buffing the effect even more. Random wikipedia claim (https://en.wikipedia.org/wiki/Prussian_blue#Medicine) says we could go up to making it as much as +66.667% more effective than baseline rads but that's only for one type of isotope's presence in the body, while the radiation is problably all of them plus continued side effects while the body recovers from cell death and the like so eh, +50% is plenty.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Suffered the curse of doing the math above. :<
  3. Load-tested in compiled test build and tested taking a dose of each, they show up on the effects screen now.

image

Additional context

Checked DDA and predictably the effects are still hidden, and prussian blue is still as useless as ever: https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/data/json/effects.json#L1118

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Dec 14, 2024
@chaosvolt chaosvolt merged commit 7ffe2cc into cataclysmbnteam:main Dec 14, 2024
9 checks passed
@chaosvolt chaosvolt deleted the on-the-blue-do-be-do branch December 14, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants