feat(balance): prussian blue and iodide effects visble on status screen, increase effectiveness of prussian blue #5811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
A suggestion that came up in the BN discord was making the prussian blue and iodine effects visible on the effects screen since it can be hard to tell it's doing anything otherwise, and since antibiotics in BN are directly visible instead of hidden we don't have to fiddle with abstracting it behind a separate dosage-tracker effect.
Along the way I noticed the effect also really doesn't seem like it recovers very much radiation, and after some quick math uh...yeah.
Describe the solution
chance_min
of prussian blue from 600 to 100. This should make it recover roughly 36 rads across an hour, which combined with the natural recovery rate makes for a 50% increase over just toughing it out (before it made you lose rads ~8.333% faster). Compare iodine reducing incoming radiation by 70% with no radiation mutations (https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/src/suffer.cpp#L1630), this makes it better than useless but reducing incoming rads is still more effective.Describe alternatives you've considered
Buffing the effect even more. Random wikipedia claim (https://en.wikipedia.org/wiki/Prussian_blue#Medicine) says we could go up to making it as much as +66.667% more effective than baseline rads but that's only for one type of isotope's presence in the body, while the radiation is problably all of them plus continued side effects while the body recovers from cell death and the like so eh, +50% is plenty.
Testing
Additional context
Checked DDA and predictably the effects are still hidden, and prussian blue is still as useless as ever: https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/data/json/effects.json#L1118