Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate clang-tidy to LLVM 18 #5497

Merged
merged 12 commits into from
Oct 5, 2024

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Oct 3, 2024

Checklist

Required

Optional

  • This PR ports commits from DDA or other cataclysm forks.
    • I have attributed original authors in the commit messages adding Co-Authored-By in the commit message.
    • I have linked the URL of original PR(s) in the description.
  • This is a PR that modifies build process or code organization.
    • Please document the changes in the appropriate location in the doc/ folder.
    • If documentation for this feature or process does not exist, please write it.
    • If the change alters versions of software required to build or work with the game, please document it.

Purpose of change

Describe the solution

please check individual commits; docs will be updated later

Describe alternatives you've considered

  • stuck in c++17 forever
  • changing 1 line of cpp file takes 1h 20m to lint

Testing

lit checks fail, but could investigate later

Additional context

@github-actions github-actions bot added docs PRs releated to docs page scripts related to game management scripts labels Oct 3, 2024
@scarf005 scarf005 force-pushed the test/clang-tidy-llvm-18 branch 6 times, most recently from ee8bf17 to d394008 Compare October 5, 2024 03:38
@github-actions github-actions bot added the src changes related to source code. label Oct 5, 2024
@scarf005 scarf005 marked this pull request as ready for review October 5, 2024 03:40
@scarf005 scarf005 force-pushed the test/clang-tidy-llvm-18 branch from d394008 to f20db61 Compare October 5, 2024 04:04
@scarf005 scarf005 force-pushed the test/clang-tidy-llvm-18 branch from f20db61 to 1196f63 Compare October 5, 2024 04:10
@scarf005 scarf005 changed the title ci: migrate clang-tidy to LLVM 18 test: migrate clang-tidy to LLVM 18 Oct 5, 2024
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images

@scarf005
Copy link
Member Author

scarf005 commented Oct 5, 2024

aaaaahhhhhhhhh

@scarf005 scarf005 merged commit 6e37f25 into cataclysmbnteam:main Oct 5, 2024
12 checks passed
@scarf005 scarf005 deleted the test/clang-tidy-llvm-18 branch October 5, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page scripts related to game management scripts src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants