feat(UI): fix odd coloration of tools/components UI, recipes showing same color as ones using rotten components #4757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
So recently, crafting GUI coloration changed to make recipes that you can attempt to craft despite lacking subskills to show with brown text. This is a Bad Idea, because "item will be rotten due to rotten ingredients" already uses brown texts, and we shouldn't have this ambiguity.
Describe the solution
In crafting_gui.cpp, set it so the text color for "could craft if known" is light grey instead of yellow, while using yellow for the "can craft but missing some skills" condition.
Reason is, I found in testing that the "could craft if known" condition also affects the UI of basically the entrire tools and components block. I was wondering why it changed to yellow for stuff you can't craft, and thought it looked utterly hiddeous. I was gonna go with red, but that made it look ugly too.
I decided it'd be less disruptive if it used shades of grey in general so that all recipes you can't attempt to craft show as grey, while yellow is reserved for recipes you can try to craft but will struggle with. Using light grey instead of dark grey will also make the UI fluff for recipes you can't currently attempt a shade of grey to designate them as not attemptable, while still being more readable than dark grey, not eye-searing yellow, and not red that blends in with missing tools/components too easily.
Describe alternatives you've considered
Testing
u
, saw bone shivs showing under a yellow name with white UI text, also saw a composite crossbow with light gray name and light gray text.Bone shiv, showing as yellow name since can craft it despite missing skill:
![image](https://private-user-images.githubusercontent.com/11582235/337830361-d99df9d1-3f56-4fb2-a82b-b40e7ebff975.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ1Mjc4NTYsIm5iZiI6MTczNDUyNzU1NiwicGF0aCI6Ii8xMTU4MjIzNS8zMzc4MzAzNjEtZDk5ZGY5ZDEtM2Y1Ni00ZmIyLWE4MmItYjQwZTdlYmZmOTc1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE4VDEzMTIzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzZDY5NzJlMTY3ZmJlNWM1YjZiOTc2MjhlMTcxZDIzNDJlNmMyMDMzNGI5MDQ2OGU4NzUyNGNjYTY0MTE4NGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.tiyljWEjJQBqYoU86ga4sc6g2J-nIEo37I_xr8LhJGI)
Bone shiv highlighted, showing UI text is white as normal since can craft:
![image](https://private-user-images.githubusercontent.com/11582235/337830372-18ecbdd7-043c-49c4-a869-08c203bdbdf9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ1Mjc4NTYsIm5iZiI6MTczNDUyNzU1NiwicGF0aCI6Ii8xMTU4MjIzNS8zMzc4MzAzNzItMThlY2JkZDctMDQzYy00OWM0LWE4NjktMDhjMjAzYmRiZGY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE4VDEzMTIzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJmN2ExMTc5ZDI0MDdhYWViODNjOGZhNDY2MGRkNDAzN2ZhNGRhNzkxYWVkYjdmZTNjODE5ZjZkYTc1NjFlOGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.IHqZQHLOoZhN3kRI6WwJtpO5nnFNqlsc-ww2UGzKMr4)
Composite crossbow, showing not craftable because not learned but has skills to craft it were it learned:
![image](https://private-user-images.githubusercontent.com/11582235/337830400-da557183-bb5f-4338-95a0-30a2f713d9ce.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ1Mjc4NTYsIm5iZiI6MTczNDUyNzU1NiwicGF0aCI6Ii8xMTU4MjIzNS8zMzc4MzA0MDAtZGE1NTcxODMtYmI1Zi00MzM4LTk1YTAtMzBhMmY3MTNkOWNlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE4VDEzMTIzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWUxZGQ4YTZiNmRmODVmMjMxNjQxOGZjZjgxZWFiMDc1NzMyZmUwMmQyZWEzYTliN2ZiZTdkZGNmZjE0ZjY2YTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Mulbd7PDNxvn64u1EYVSCQTSU1-zbabyd7qolFX6-M0)
Composite crossbow highlighted, showing UI text is light gray instead of yellow now:
![image](https://private-user-images.githubusercontent.com/11582235/337830421-aec9dcab-834a-4139-abef-5a05e6648163.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzQ1Mjc4NTYsIm5iZiI6MTczNDUyNzU1NiwicGF0aCI6Ii8xMTU4MjIzNS8zMzc4MzA0MjEtYWVjOWRjYWItODM0YS00MTM5LWFiZWYtNWEwNWU2NjQ4MTYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEyMTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMjE4VDEzMTIzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUyNGU1MmMwMjdiOTczNDM2NGM4Y2M1MjlhODZiYmY2N2MwMDNiMzM5NzY3YjgwYTJlNDlkMmYyNmRlYTkxMDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FbgwBssPgA0nQw0ggeNEeAJzFDztOnRexmZ_i20Z5EQ)
Additional context
Checklist