Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(balance): consistency updates to harvest entries #4755

Conversation

chaosvolt
Copy link
Member

Purpose of change

This separates out the JSON and documentation changes that crept into #4751, which I initially did because they were relevant to implementing and documenting the decay feature. Now that the intended implementation is able to use a monster's harvest entries directly, but also it's left in draft because the implementation has some flaws in it, I figured I'd yoink the now-unrelated updates as a separate PR so they won't be held up by technical issues.

Describe the solution

JSON changes:

  1. Fixed several cases of mutant human harvest entries having regular bones instead of human bones.
  2. Set most arthopods to have more consistent use of sinew, and more consistent ratios of chitin. Left non-armored centipedes at a lower than standard (but no longer pathetically tiny) ratio since the comment notes they're meant to be more sinewy than anything else.
  3. Toned down the mass ratios for hydrogen sacs in flying harvest entries, especially since while I have ideas for what to do with them they really don't need to be that high.
  4. Fixed acid ant queens having weirdly-defined butcher yields that vastly limited their max butcher returns, instead using same ratios as regular acid ants for now. Later on should we add acid ant eggs they likely could drop some like other queen monsters do.
  5. Made the mass ratios of sinew drops consistent across all creatures that drop them. Unlike initially, I went ahead and used the ratio human harvest entries were using as the standard instead of the much smaller amount most animals used.
  6. Fixed up cyborg harvest also using a weird max for its bone yield instead of a standard ratio.
  7. Updated bone mass ratios for human harvest to fit the ratio most other harvest entries use.
  8. As with acidant queens, updated fungal boss creatures to use a consistent mass ratios as regular fungals use, and removed spawns of non-fungal plant marrow on them.
  9. Toned down fibrous stalk yields in triffids, to be consistent with amounts in fungaloids.

Documentation changes:

  1. Added missing documentation of harvest entry to monster documentation, along with explaining the fallback behavior of using human harvest that I found.

Describe alternatives you've considered

Leaving it in the other PR and just waiting to see if I can sort out how to make decay behavior work right with corpses rotting out of the reality bubble.

Testing

Checked affected file for syntax and lint errors.

Additional context

Checklist

@scarf005 scarf005 merged commit 5277097 into cataclysmbnteam:main Jun 8, 2024
10 checks passed
@chaosvolt chaosvolt deleted the separate-harvest-rebalance-from-decay-pr branch June 8, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants