Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update JSON of pet carrier items with correct property #4749

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

chaosvolt
Copy link
Member

Purpose of change

Turns out #4713 also changed a properly in the JSON for pet carrier iuse for some wacky reason.

Describe the solution

Updated pet carrier items to use creature_size_capacity instead of monster_size_capacity, in both vanilla items and in mods (one result in Aftershock was found).

Describe alternatives you've considered

Changing the string back to monster_size_capacity because I have no goddamn idea why someone would ever make such a pointlessly minor change that does nothing but require the JSON to be updated, let alone why it got included in an accessibility port.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Scooped up a dog in a pet carrier, it works as expected.

Additional context

Checklist

@chaosvolt chaosvolt enabled auto-merge (squash) June 6, 2024 17:19
@github-actions github-actions bot added JSON related to game datas in JSON format. mods PR changes related to mods. labels Jun 6, 2024
Copy link
Collaborator

@KheirFerrum KheirFerrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed issue, confirmed solution. Should be good to merge.

@chaosvolt chaosvolt merged commit c9a1b6e into cataclysmbnteam:main Jun 6, 2024
10 checks passed
@chaosvolt chaosvolt deleted the goofy-ahh-pet-carriers branch June 6, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format. mods PR changes related to mods.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants