Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document trap data in json_info.md #3971

Merged

Conversation

chaosvolt
Copy link
Member

Purpose of change

thanks i hate it

Fixes #3965

Describe the solution

Slapped down a section in json_info.md dedicated to documenting the various things traps are able to do. I think I got it all, all the important stuff if nothing else.

Also lists a summary of all trapfuncs available in a subsection.

Describe alternatives you've considered

Screaming.

Testing

Used my eyes. I dunno if we have a formatter for document files...

Additional context

Checklist

@github-actions github-actions bot added the docs PRs releated to docs page label Dec 24, 2023
@chaosvolt chaosvolt changed the title feat(interface): document trap data in json_info.md fix: document trap data in json_info.md Dec 24, 2023
Copy link
Contributor

autofix-ci bot commented Dec 24, 2023

The Autofix app has automatically formatted this Pull Request.

If you edit your PR on web UI, you can ignore this message.
If you edit your PR locally, YOU MUST DO EITHER OF THE FOLLOWING:

  • Run git pull to merge the automated commit into your local copy of the PR branch.
  • Format your code locally, and force push to your PR branch.

If you don't do this, your following work will be based on the old commit, and cause MERGE CONFLICT.

Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@NappingOcean
Copy link
Contributor

I've always been curious about traps. Thanks.

@scarf005 scarf005 merged commit 4e72e7b into cataclysmbnteam:main Dec 25, 2023
3 checks passed
@chaosvolt chaosvolt deleted the why-is-this-not-already-a-thing branch December 25, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write documentation for trap data
4 participants