Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(port): unhardcode oter_id migrations #3840

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

Vollch
Copy link
Contributor

@Vollch Vollch commented Dec 7, 2023

Purpose of change

Getting rid of hardcoded legacy, and allowing easier migration

Describe the solution

Ported:

Describe alternatives you've considered

Testing

Added new oter to json, and successfully migrated it

Additional context

Checklist

@github-actions github-actions bot added docs PRs releated to docs page src changes related to source code. JSON related to game datas in JSON format. labels Dec 7, 2023
Copy link
Contributor

autofix-ci bot commented Dec 7, 2023

The Autofix app has automatically formatted this Pull Request.

If you edit your PR on web UI, you can ignore this message.
If you edit your PR locally, YOU MUST DO EITHER OF THE FOLLOWING:

  • Run git pull to merge the automated commit into your local copy of the PR branch.
  • Format your code locally, and force push to your PR branch.

If you don't do this, your following work will be based on the old commit, and cause MERGE CONFLICT.

@scarf005 scarf005 changed the title refactor(port): unhardcode oter_id migrations refactor(port): unhardcode oter_id migrations Dec 7, 2023
@scarf005 scarf005 self-requested a review December 9, 2023 01:08
@scarf005 scarf005 self-assigned this Dec 9, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

LGTM.

@scarf005 scarf005 added this pull request to the merge queue Dec 9, 2023
Merged via the queue into cataclysmbnteam:upload with commit c0a3d23 Dec 9, 2023
14 checks passed
@Vollch Vollch deleted the migration branch December 9, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PRs releated to docs page JSON related to game datas in JSON format. src changes related to source code. translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants