-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(port): allow vertical movement for avatar in water #3764
Conversation
Do we really need all that spam in comments..? |
it was supposed to be a friendly help message for first time contributors, because there has been much pain around formatting. haven't seen multiple comments from bots, however. have there been one? |
if the comments get too spammy then i'll disable it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2023-11-27_13-42-28.mp4
it's not possible to go down from 3x3 hole but only go up, but otherwise neat addition.
3c060a0
Well, yeah. Diving mechanic and freshwater mapgens doesn't perfectly match each others. I'm not decided yet what would be the best way to fix it. |
Purpose of change
Now you can actually swim out of freshwater research station through underwater hatch.
Describe the solution
Ported CleverRaven/Cataclysm-DDA#65174.
Describe alternatives you've considered
None.
Testing
Swim around. Diving test is also passing.
Additional context
Checklist