Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Convert non-pistol only energy weapon mods to be compatible with all energy weapons. #3688

Merged

Conversation

KheirFerrum
Copy link
Collaborator

Purpose of change

Discord described issue with some non-pistol energy weapon mods not applying due to mod target category being narrow. Expanded it to all energy weapons as this doesn't change vanilla behavior but allows mods to use it in more versatile ways without overwriting it.

Describe the solution

Trimmed down the mod target category to any weapon with energy weapons

Describe alternatives you've considered

  • Add machine gun category so that it fits more closely with original format that included both pistol and rifle skill using guns.
    • I can't see the harm in allowing it on SMG and Shotguns from mods. If/when we add new energy weapons we may then balance this at our leisure.

Testing

  • Mods still installable in both A7 and v29

Additional context

Checklist

Now works with all energy weapons
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 16, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scarf005 scarf005 added this pull request to the merge queue Nov 16, 2023
Merged via the queue into cataclysmbnteam:upload with commit 7d7dfe3 Nov 16, 2023
12 checks passed
@KheirFerrum KheirFerrum deleted the energy-weapon-mod-update branch November 19, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants