Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): correct electric firestarter recipe #3682

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

yay855
Copy link
Contributor

@yay855 yay855 commented Nov 15, 2023

Purpose of change

The electric firestarter recipe accidentally used regular steel wires instead of copper wire.

Describe the solution

I changed the wire component in its recipe to cable.

Describe alternatives you've considered

Testing

No json errors.

Additional context

Checklist

If this is a C++ PR that modifies JSON loading or behavior:

  • Document the changes in the appropriate location in the doc/ folder.
  • If documentation for this feature does not exist, please write it or at least note its lack in PR description.
  • New localizable fields need to be added to the lang/bn_extract_json_strings.sh script if it does not support them yet.
  • If applicable, add checks on game load that would validate the loaded data.
  • If it modifies format of save files, please add migration from the old format.

If this is a PR that modifies build process or code organization:

  • Please document the changes in the appropriate location in the doc/ folder.
  • If documentation for this feature or process does not exist, please write it.
  • If the change alters versions of software required to build or work with the game, please document it.

If this is a PR that removes JSON entities:

  • The removed JSON entities have new entries in data/json/obsoletion/ folder.

Made electric firestarter no longer have only 5 charges, made it crafted with electric wire instead of steel wire.
@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 15, 2023
@yay855 yay855 changed the title Electric firestarter fix fix:Electric firestarter recipe, max_charges removal Nov 15, 2023
@scarf005 scarf005 changed the title fix:Electric firestarter recipe, max_charges removal fix: electric firestarter recipe, max_charges removal Nov 15, 2023
@scarf005 scarf005 changed the title fix: electric firestarter recipe, max_charges removal fix(content): correct electric firestarter recip and max charges Nov 15, 2023
Apparently its there to fix a bug, I'd forgotten.
@scarf005 scarf005 changed the title fix(content): correct electric firestarter recip and max charges fix(content): correct electric firestarter recipe and max charges Nov 15, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the max charges removal is reverted in last commit, if the PR is ready, could we change PR title and description to match the changes?

@scarf005 scarf005 marked this pull request as draft November 17, 2023 06:51
@yay855 yay855 changed the title fix(content): correct electric firestarter recipe and max charges fix(content): correct electric firestarter recipe Nov 17, 2023
@scarf005 scarf005 marked this pull request as ready for review November 18, 2023 06:37
@scarf005 scarf005 added this pull request to the merge queue Nov 18, 2023
Merged via the queue into cataclysmbnteam:upload with commit b6abff5 Nov 18, 2023
14 checks passed
@yay855 yay855 deleted the electric-firestarter-fix branch November 30, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants