fix: crash when trying to load a world while missing a mod #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
approved these changes
Nov 15, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Nov 15, 2023
0d96ee5
13 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of change
Fix crash when when trying to load a world while missing one of the mods that the world uses.
Describe the solution
Skip invalid mods when de-/serializing data.
Describe alternatives you've considered
Banning modded saves from being eligible to be reported for bugs.
Testing
Save from #3665 now loads on vanilla BN
Additional context
Checklist