Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use import map for ts imports #3674

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

scarf005
Copy link
Member

@scarf005 scarf005 commented Nov 15, 2023

Purpose of change

simplifies version management for typescript files.

Describe the solution

used import map in typescript files for easier dependencies version control.

Additional Context

e.g

// before
import { walk } from "https://deno.land/[email protected]/fs/walk.ts"
// after
import { walk } from "$std/fs/walk.ts"

this makes updating version (e.g: 0.201.0 -> 0.206.0) across entire modules easier.

@github-actions github-actions bot added the scripts related to game management scripts label Nov 15, 2023
@scarf005 scarf005 requested a review from chaosvolt November 15, 2023 02:54
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have zero experience with deno and typescript stuff so uh
image

@scarf005 scarf005 added this pull request to the merge queue Nov 15, 2023
Merged via the queue into cataclysmbnteam:upload with commit a63b500 Nov 15, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scripts related to game management scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants