fix: vehicle split crash #3559
Merged
fix: vehicle split crash #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
approved these changes
Nov 5, 2023
Merged
via the queue into
cataclysmbnteam:upload
with commit Nov 5, 2023
12a8325
14 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes a crash when vehicles are split"
Purpose of change
Fixes #3552.
Describe the solution
Rejig the constructors for vehicles and their parts. Also cleanup the removed parts right after the split to prevent further bugs.
Additional context
I've also done a bit of cleanup and removed an unused monster constructor and added their missed inventory to the other. There's also a few references added to remove unnecessary copies.