fix: prevent UB on test suite exit. #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
changed the title
scarf005
approved these changes
Nov 5, 2023
|
One of the runners seems to be reliably running out of resources. I'll see if it's related to some of the other problems we've found first and come back to this. |
Merged
via the queue into
cataclysmbnteam:upload
with commit Nov 5, 2023
03cb7f7
10 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Remove UB on test suite exit"
Purpose of change
I'm hoping this fixes #3551.
Describe the solution
When the player's activity is set to null it doesn't clean up the activities targets as well. When global deconstruction happens stuff gets cleaned up in a random order. If the target safe_references get cleaned up after the global structures they use it causes UB.
Testing
Can't reproduce this one locally so we'll have to see if the suite here works.