Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turrets aiming moving vehicle it cannot see #3180

Merged

Conversation

scarf005
Copy link
Member

Summary

SUMMARY: Bugfixes "Fixed turrets aiming moving vehicle it cannot see"

Purpose of change

while #2589 fixed turrets firing through walls and floors, turrets still ignored their visibility for moving vehicles.

fix https://gall.dcinside.com/board/view/?id=rlike&no=447553

Describe the solution

also check for visibility in turrets

Describe alternatives you've considered

haha turrets go brrrrrrrrt

Testing

before.mp4
after.mp4

@github-actions github-actions bot added the src changes related to source code. label Sep 19, 2023
Copy link
Member

@chaosvolt chaosvolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Compiled and load-tested.
  2. Spawned in an APC and a turret, with a curtain added over the window so it couldn't see the driver.
  3. Scooted forward in broad daylight, turret fires on the vehicle from a good distance away.
  4. Set time to midnight, have to drive right by the turret to get shot at.

@chaosvolt chaosvolt merged commit 63afb0f into cataclysmbnteam:upload Sep 19, 2023
16 checks passed
@scarf005 scarf005 deleted the fix-night-turret-omnisciency branch September 19, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
src changes related to source code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants