Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand range of volume limits for certain holsters #3159

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

chaosvolt
Copy link
Member

Summary

SUMMARY: Balance "Ankle holsters, holsters, and XL holsters can now hold a wider range of guns"

Purpose of change

As mentioned in #3158, messing with the range of volumes holsters can fit was on my list as one idea to help alleviate various issues with fitting guns in storage being fairly fiddly, especially when magazines and gunmods get added to the fray.

Describe the solution

  1. Changed the regular holster's minimum volume from 300 ml to 250 ml, and its maximum volume from 800 ml to 1 liter. Change to the minimum notably affects the Walther P22 and SIG Mosquito (250 and 263 ml, both looking decent and not pocket-pistol size IRL from what I can tell). The change to maximum volume notably affects the Colt Navy (851 ml, standard barrel length IRL is a whole half an inch shorter than the Colt Army that fit in a holster comfortably), homemade hand cannon (1 liter), Magnum Research BFR (1 liter, could maybe bump its volume up if we still want it exclusive to XL holster?), and V-29 laser pistol (historically been a pain in my ass as what holster it belongs in kept changing, back when Arcana had a profession start with one).
  2. Changed the XL holster's max volume from 1.25 liters to 1.5 liters. This increases the gap in utility between the normal holster and XL holster from 450 ml to 500 ml. Notably affects the Steyr AUG (1.5 L), handmade carbine (1.5 L), Serbu BFG-50 (1387 ml, seems like that could afford a tad more volume if desired?) and Remington 870 MCS (1284 ml) among others.
  3. Changed the ankle holster's max volume from 400 ml to 500 ml. This makes it consistent with the fast draw and deep concealment holsters, being designed for small guns. Notably affects the various models of Glock (typically 443-500 ml), SIG P320 Compact (462 ml), S&W Model 10 (402 ml, evidently made deliberately so a moderately slim revolver couldn't fit in this :V), Colt M1860 Army (486 ml), M1911 (500 ml), various interchangeable 9mm pistols, 12 gauge pistol (500 ml), flaregun (500 ml), among others.

Describe alternatives you've considered

  1. Messing with the max volume of the survivor's harness in either direction because a max volume of 3750 ml feels mildly fucking cursed. Buffing it to 4 L would notably affect: Weatherby Mark V (3761 ml), Mark 19 grenade launcher (4 L, that is hilariously cursed given it weighs over 75 pounds!)
  2. As mentioned, increasing the volume of certain guns like the BFR (to 1.1-1.25 L), BFG-50 (to 1.6-1.75 L) to nudge them out of being usable in holsters they may feel weight in.
  3. A few weapons notably still have volumes that seem out of logical range, notably the AR pistol and Mini Draco would be reasonable to fit on an XL holster but have volumes of 1758 ml and 2167 ml (more than the Beretta ARX-160 and only a bit less than the SKS) respectively.
  4. Nerfing the ankle holster down to a max of 250 ml instead. I feel like this would only be a sane option if we did some hardcore sanity-checking of pocket pistol volumes so ech.
  5. Screaming at all these volume amounts that are all like a dozen ml over a threshold visibly for no other reason than because DDA wanted to play merry hell with holster usage, and rounding a fuckton of gun volumes up and down until it becomes slightly less of a headache to work with.

Testing

  1. Checked affected file for syntax and lint errors.
  2. Sifted through search in folder to get a rough idea of what guns will benefit from this, as noted above.

Additional context

At some point I intend to also mess with draw costs, though sheathes are where the real wacky draw costs can be found. A fair while ago I'd mused upon adding a wrist sheath for more delicious tacticool but the logically-fast draw speed currently doesn't matter as sheathes all lean towards a draw cost of a fraction of a second, and the way skill reduces skill cost also evidently is a tad overtuned. One of these days probably, weh.

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Sep 16, 2023
Copy link
Member

@scarf005 scarf005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also LGTM

@scarf005 scarf005 merged commit 409f819 into cataclysmbnteam:upload Sep 16, 2023
14 checks passed
@chaosvolt chaosvolt deleted the holsters-go-nyoom branch September 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants