feat(port): move vehicles in elevator #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
force-pushed
the
move-vehicle-in-elevator
branch
2 times, most recently
from
7d705cc to
54e6a10
Compare
scarf005
force-pushed
the
move-vehicle-in-elevator
branch
from
185e686 to
3bcfc72
Compare
scarf005
force-pushed
the
move-vehicle-in-elevator
branch
from
7f97c05 to
51a12e2
Compare
andrei8l
reviewed
Sep 16, 2023
prevent exciting magic numbers from happening Co-authored-by: andrei <[email protected]>
prevents exciting amalgamations from happening
scarf005
force-pushed
the
move-vehicle-in-elevator
branch
from
d4ca2e2 to
4b5bff5
Compare
make MSYS2 happy
scarf005
force-pushed
the
move-vehicle-in-elevator
branch
from
eb0cef3 to
f1780ca
Compare
chaosvolt
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
- Compiled and load-tested.
- Located a minilab and spawned in a shopping cart, filled it with some loot.
- Moving up and down the elevator takes the cart with me as expected. Contents stay in the cart and don't seem to change. If I was dragging the cart, I silently let go of it but no errors occur.
- Spawned in and recruited a companion NPC, loaded us into a sidecar motorocycle on the elevator.
- We stay in our seats when I shift our elevation, engine stays on and doesn't do anything weird.
- Backing the bike partway out of the elevator and hitting the switch cancels the elevator instead of cutting the vehicle in half, metal as fuck though that would've been.
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Features "Allow elevators to transport vehicles, and choose arbitrary floor"
Purpose of change
the (not) long awaited sequel of #1531.
looting labs with shopping carts would be very convenient.
Describe the solution
port CleverRaven/Cataclysm-DDA#58840 by @andrei8l
Describe alternatives you've considered
port more overmap/submap PRs first?
Testing
vehicles are moved together (with their directions kept)
2023-09-16_20-13-28.mp4
creatures/npc are shoved away
2023-09-16_20-45-54.mp4
vehicles can block the elevator from working
vehicles at destination floor is also checked to prevent amalgamation
2023-09-16_21-20-52.mp4
Additional notes
might have to port these as well