fix: allow speedloader capacity to be smaller than gun's #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
changed the title
scarf005
force-pushed
the
speedloader-only-check-bigger
branch
from
c64ff1f to
7821bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Allowed speedloader capacity to be smaller than gun's capacity"
Purpose of change
original discussion: https://discord.com/channels/830879262763909202/830916415182733322/1150400794189889606
e.g it should be ok to use a 4-rounds speedloader for shotgun of 8-rounds capacity.
Describe the solution
changed the condition from
speedloader capacity != gun capacitytospeedloader capacity > gun capacityDescribe alternatives you've considered
remove the check altogether? tho using 20-rounds speedloader for shotgun of 8-rounds capacity might be weird.
Testing
local tests passed.